-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add geos, libzip, protobuf and qgis #80
base: latest
Are you sure you want to change the base?
Conversation
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF | ||
# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
||
# https://tracker.debian.org/pkg/gdal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing adaption
# https://tracker.debian.org/pkg/gdal | ||
|
||
set(version master) | ||
set(download_hash SHA256=a06b47271827892f1897464c04a2a484f682f930d96b4d0329634512e973fe29) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't work for a dynamic target like master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either don't use a hash for the tarballs, or use git instead.
I didn't try QGIS yet, except for the source step. But the other three packages build well Android Arm 64 bit. The CI should pick up geos via gdal when building OpenOrienteering Mapper. I can run CI with the QGIS target once Qt 5.15 is ready. Which needs an updated Android toolchain... |
protobuf-3.6.1.cmake
Outdated
add_custom_target(protobuf-${patch_version}-source) | ||
set_property(TARGET protobuf-${patch_version}-source | ||
PROPERTY SB_SOURCE_DIR "${PROJECT_BINARY_DIR}/source/protobuf-source-${patch_version}/cmake" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an undocumented way to handle a non-standard source directory. I use it for CI of OpenOrienteering Mapper (and CupCalculator), with Azure Pipeline's original git checkout. I should use it for libpolyclipping, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it took me a while to figure out a workaround
8c719f1
to
a9133f7
Compare
6f56643
to
eb201ee
Compare
Required for qtimageformats.
Required for Qt 5.15 (tablet events).
Use (legacy) ANDROID_HOME and ANDROID_NDK_HOME environment variables, as provided by Azure Pipelines.
c1a486b
to
1107bc3
Compare
Libzip doesn't build with android-16 (
Bumping to android-21 fixes the build |
I guess this will need to become a configuration option. I'm going continue building for android-16 (Qt 5.12) as long as the good old Samsung Note tablets with S-Pen refuse to die even in hard field work. |
I guess it's already configurable, untested superbuild/android-toolchain-ndk-r21d.cmake Lines 119 to 127 in b828f74
|
F.Y.I
Maybe there is something of interest